Fix torture tests setup #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
=========================================
- Coverage 78.8% 78.1% -0.8%
+ Complexity 85 84 -1
=========================================
Files 10 10
Lines 421 421
Branches 44 44
=========================================
- Hits 332 329 -3
- Misses 63 65 +2
- Partials 26 27 +1 ☔ View full report in Codecov by Sentry. |
DavyLandman
approved these changes
Feb 14, 2025
Member
DavyLandman
left a comment
DavyLandman
left a comment
There was a problem hiding this comment.
Ouch, that's a painful one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, implicitly, the
TortureTestsrelied on theBundlingTeststo be run earlier, because:@BeforeAllof theBundlingTestsconfigured Awaitility in a way that was also needed by theTortureTests(setting the default timeout long enough).TortureTestsdidn't have its own@BeforeAllto do this configuration.In earlier CI runs, coincidentally, the
BundlingTestswere indeed run before theTortureTests, so it all went fine. In recent CI runs, though, the order was the other way around, causing them to inexplicably fail.This PR adds a
@BeforeAllto theTortureTeststo make the CI runs predicable again. This PR also fixes a few warnings to improve the code quality of the tests.